diff options
| author |   Feras Daoud <ferasda@mellanox.com> | 2016-12-28 14:47:20 +0200 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2017-01-12 13:59:56 -0500 |
| commit | 29da686dff757968fbf5a9bb5246070ddf602664 (patch) | |
| tree | 1389be462641e028cbcdc72315c559a36feba2fd | |
| parent | RDMA/ocrdma: Replace BUG() with BUG_ON() (diff) | |
| download | linux-dev-29da686dff757968fbf5a9bb5246070ddf602664.tar.xz linux-dev-29da686dff757968fbf5a9bb5246070ddf602664.zip | |
IB/ipoib: When given an invalid UD MTU, give debug msg
In datagram mode, the IB UD (Unreliable Datagram) transport is used
so the MTU of the interface is equal to the IB L2 MTU minus the
IPoIB encapsulation header. Any request to change the MTU value
above the maximum range will change the MTU to the max allowed, but
will not show any warning message. An ipoib_warn is issued in such
cases, letting the user know that even though the value is legal,
it can't be currently applied.
Signed-off-by: Feras Daoud <ferasda@mellanox.com>
Signed-off-by: Noa Osherovich <noaos@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_main.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 3ce0765a05ab..b2a75d85bc23 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -229,6 +229,10 @@ static int ipoib_change_mtu(struct net_device *dev, int new_mtu) priv->admin_mtu = new_mtu; + if (priv->mcast_mtu < priv->admin_mtu) + ipoib_dbg(priv, "MTU must be smaller than the underlying " + "link layer MTU - 4 (%u)\n", priv->mcast_mtu); + dev->mtu = min(priv->mcast_mtu, priv->admin_mtu); return 0; |