diff options
| author |   Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2022-02-14 17:59:38 -0800 |
|---|---|---|
| committer |   Marcel Holtmann <marcel@holtmann.org> | 2022-02-24 21:05:21 +0100 |
| commit | 29fb608396d6a62c1b85acc421ad7a4399085b9f (patch) | |
| tree | f3f5c91a3ff17fbaa505e913512d76133f709e5e | |
| parent | Bluetooth: fix data races in smp_unregister(), smp_del_chan() (diff) | |
| download | linux-dev-29fb608396d6a62c1b85acc421ad7a4399085b9f.tar.xz linux-dev-29fb608396d6a62c1b85acc421ad7a4399085b9f.zip | |
Bluetooth: Fix bt_skb_sendmmsg not allocating partial chunks
Since bt_skb_sendmmsg can be used with the likes of SOCK_STREAM it
shall return the partial chunks it could allocate instead of freeing
everything as otherwise it can cause problems like bellow.
Fixes: 81be03e026dc ("Bluetooth: RFCOMM: Replace use of memcpy_from_msg with bt_skb_sendmmsg")
Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://lore.kernel.org/r/d7206e12-1b99-c3be-84f4-df22af427ef5@molgen.mpg.de
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215594
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Tested-by: Paul Menzel <pmenzel@molgen.mpg.de> (Nokia N9 (MeeGo/Harmattan)
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
| -rw-r--r-- | include/net/bluetooth/bluetooth.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h index 4b3d0b16c185..a647e5fabdbd 100644 --- a/include/net/bluetooth/bluetooth.h +++ b/include/net/bluetooth/bluetooth.h @@ -506,8 +506,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk, tmp = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom); if (IS_ERR(tmp)) { - kfree_skb(skb); - return tmp; + return skb; } len -= tmp->len; |