diff options
| author |   Minghao Chi <chi.minghao@zte.com.cn> | 2022-05-16 07:26:46 +0000 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2022-05-17 13:02:34 +0200 |
| commit | 29fd3ca1779f6997d15c6d8f1ab119128e4bab61 (patch) | |
| tree | 99206c7c4489967cd87ae359f10d83a8c8fe87d4 | |
| parent | ax25: merge repeat codes in ax25_dev_device_down() (diff) | |
| download | linux-dev-29fd3ca1779f6997d15c6d8f1ab119128e4bab61.tar.xz linux-dev-29fd3ca1779f6997d15c6d8f1ab119128e4bab61.zip | |
qed: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220516072646.1651109-1-chi.minghao@zte.com.cn
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index c5003fa1a25e..c91898be7c03 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -823,7 +823,6 @@ static void qed_slowpath_irq_free(struct qed_dev *cdev) for_each_hwfn(cdev, i) { if (!cdev->hwfns[i].b_int_requested) break; - synchronize_irq(cdev->int_params.msix_table[i].vector); free_irq(cdev->int_params.msix_table[i].vector, &cdev->hwfns[i].sp_dpc); } |