diff options
| author |   zhong jiang <zhongjiang@huawei.com> | 2018-09-19 04:16:09 -0400 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-12-03 13:27:55 -0500 |
| commit | 2c4746cf45b957962c03f1c10a3d068d7db68924 (patch) | |
| tree | 3b786df4b9d5f4bfa79982420c1cfb0cd8e85101 | |
| parent | media: usb: Use kmemdup instead of duplicating its function. (diff) | |
| download | linux-dev-2c4746cf45b957962c03f1c10a3d068d7db68924.tar.xz linux-dev-2c4746cf45b957962c03f1c10a3d068d7db68924.zip | |
media: dvb-frontends: Use kmemdup instead of duplicating its function
kmemdup has implemented the function that kmalloc() + memcpy().
We prefer to kmemdup rather than code opened implementation.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| -rw-r--r-- | drivers/media/dvb-frontends/lgdt3306a.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index 0e1f5daaf20c..cee9c83e48de 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -2205,15 +2205,13 @@ static int lgdt3306a_probe(struct i2c_client *client, struct dvb_frontend *fe; int ret; - config = kzalloc(sizeof(struct lgdt3306a_config), GFP_KERNEL); + config = kmemdup(client->dev.platform_data, + sizeof(struct lgdt3306a_config), GFP_KERNEL); if (config == NULL) { ret = -ENOMEM; goto fail; } - memcpy(config, client->dev.platform_data, - sizeof(struct lgdt3306a_config)); - config->i2c_addr = client->addr; fe = lgdt3306a_attach(config, client->adapter); if (fe == NULL) { |