diff options
| author |   Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp> | 2007-07-11 17:11:45 +0900 |
|---|---|---|
| committer |   Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2007-07-18 16:58:45 +0300 |
| commit | 2db61c95c03d08bb885c87a816540e75190c924a (patch) | |
| tree | 1376072b9ed06ff51e35c50be6fec569ee7a3e61 | |
| parent | UBI: fix overflow bug (diff) | |
| download | linux-dev-2db61c95c03d08bb885c87a816540e75190c924a.tar.xz linux-dev-2db61c95c03d08bb885c87a816540e75190c924a.zip | |
UBI: cleanup usage of try_module_get
The use of try_module_get(THIS_MODULE) in ubi_get_device_info does not
offer real protection against unexpected driver unloads, since we could
be preempted before try_modules_get gets executed. It is the caller who
should manipulate the refcounts. Besides, ubi_get_device_info is an
exported symbol which guarantees protection when accessed through
symbol_get.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
| -rw-r--r-- | drivers/mtd/ubi/kapi.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c index 14c66b48798e..78cae4940875 100644 --- a/drivers/mtd/ubi/kapi.c +++ b/drivers/mtd/ubi/kapi.c @@ -37,12 +37,8 @@ int ubi_get_device_info(int ubi_num, struct ubi_device_info *di) { const struct ubi_device *ubi; - if (!try_module_get(THIS_MODULE)) - return -ENODEV; - if (ubi_num < 0 || ubi_num >= UBI_MAX_DEVICES || !ubi_devices[ubi_num]) { - module_put(THIS_MODULE); return -ENODEV; } @@ -52,7 +48,6 @@ int ubi_get_device_info(int ubi_num, struct ubi_device_info *di) di->min_io_size = ubi->min_io_size; di->ro_mode = ubi->ro_mode; di->cdev = MKDEV(ubi->major, 0); - module_put(THIS_MODULE); return 0; } EXPORT_SYMBOL_GPL(ubi_get_device_info); |