diff options
| author |   Peter Zijlstra <peterz@infradead.org> | 2020-04-21 12:09:13 +0200 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-06-15 14:10:22 +0200 |
| commit | 3070da33400c18e0454832425a530d2d0e6a6fcf (patch) | |
| tree | dd70c7fbfa4bff856abca64d94f8b31ee12dcf93 | |
| parent | sched,mmc: Convert to sched_set_fifo*() (diff) | |
| download | linux-dev-3070da33400c18e0454832425a530d2d0e6a6fcf.tar.xz linux-dev-3070da33400c18e0454832425a530d2d0e6a6fcf.zip | |
sched,spi: Convert to sched_set_fifo*()
Because SCHED_FIFO is a broken scheduler model (see previous patches)
take away the priority field, the kernel can't possibly make an
informed decision.
No effective change.
Cc: broonie@kernel.org
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
| -rw-r--r-- | drivers/platform/chrome/cros_ec_spi.c | 6 | ||||
| -rw-r--r-- | drivers/spi/spi.c | 4 |
2 files changed, 2 insertions, 8 deletions
diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c index debea5c4c829..c20a43a97040 100644 --- a/drivers/platform/chrome/cros_ec_spi.c +++ b/drivers/platform/chrome/cros_ec_spi.c @@ -709,9 +709,6 @@ static void cros_ec_spi_high_pri_release(void *worker) static int cros_ec_spi_devm_high_pri_alloc(struct device *dev, struct cros_ec_spi *ec_spi) { - struct sched_param sched_priority = { - .sched_priority = MAX_RT_PRIO / 2, - }; int err; ec_spi->high_pri_worker = @@ -728,8 +725,7 @@ static int cros_ec_spi_devm_high_pri_alloc(struct device *dev, if (err) return err; - err = sched_setscheduler_nocheck(ec_spi->high_pri_worker->task, - SCHED_FIFO, &sched_priority); + err = sched_set_fifo(ec_spi->high_pri_worker->task); if (err) dev_err(dev, "Can't set cros_ec high pri priority: %d\n", err); return err; diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 8158e281f354..5a4f0bfce474 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1592,11 +1592,9 @@ EXPORT_SYMBOL_GPL(spi_take_timestamp_post); */ static void spi_set_thread_rt(struct spi_controller *ctlr) { - struct sched_param param = { .sched_priority = MAX_RT_PRIO / 2 }; - dev_info(&ctlr->dev, "will run message pump with realtime priority\n"); - sched_setscheduler(ctlr->kworker_task, SCHED_FIFO, ¶m); + sched_set_fifo(ctlr->kworker_task); } static int spi_init_queue(struct spi_controller *ctlr) |