diff options
| author |   Wolfram Sang <wsa+renesas@sang-engineering.com> | 2018-10-19 21:15:26 +0200 |
|---|---|---|
| committer |   Wolfram Sang <wsa@the-dreams.de> | 2018-10-20 15:25:59 +0200 |
| commit | 31d86033a0749a0463ea654130b2de5c163154f1 (patch) | |
| tree | 7389ea1d3cfd365ee474d4b0d2921434ac3b81fa | |
| parent | MAINTAINERS: Add entry for Broadcom STB I2C controller (diff) | |
| download | linux-dev-31d86033a0749a0463ea654130b2de5c163154f1.tar.xz linux-dev-31d86033a0749a0463ea654130b2de5c163154f1.zip | |
i2c: rcar: cleanup DMA for all kinds of failure
DMA needs to be cleaned up not only on timeout, but on all errors where
it has been setup before.
Fixes: 73e8b0528346 ("i2c: rcar: add DMA support")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
| -rw-r--r-- | drivers/i2c/busses/i2c-rcar.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 52cf42b32f0a..4aa7dde876f3 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -806,8 +806,12 @@ static int rcar_i2c_master_xfer(struct i2c_adapter *adap, time_left = wait_event_timeout(priv->wait, priv->flags & ID_DONE, num * adap->timeout); - if (!time_left) { + + /* cleanup DMA if it couldn't complete properly due to an error */ + if (priv->dma_direction != DMA_NONE) rcar_i2c_cleanup_dma(priv); + + if (!time_left) { rcar_i2c_init(priv); ret = -ETIMEDOUT; } else if (priv->flags & ID_NACK) { |