diff options
| author |   Heiner Kallweit <hkallweit1@gmail.com> | 2018-12-19 00:43:58 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-12-18 22:07:20 -0800 |
| commit | 33f18c96afdf4da20014f834874e2820ee880cde (patch) | |
| tree | 8b14ad4051bf1ec504e409103cf42286e853f3b3 | |
| parent | MAINTAINERS: Add a maintainer for Microsemi switches (diff) | |
| download | linux-dev-33f18c96afdf4da20014f834874e2820ee880cde.tar.xz linux-dev-33f18c96afdf4da20014f834874e2820ee880cde.zip | |
net: ethernet: don't set phylib state CHANGELINK in drivers
After phy_start() phylib takes care of all needed actions, including
aneg settings and checking link state. There's no need to set state
PHY_CHANGELINK in drivers.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/amd/au1000_eth.c | 5 | ||||
| -rw-r--r-- | drivers/net/ethernet/ti/cpmac.c | 1 |
2 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index 7c1eb304c27e..e833d1b3fe18 100644 --- a/drivers/net/ethernet/amd/au1000_eth.c +++ b/drivers/net/ethernet/amd/au1000_eth.c @@ -940,11 +940,8 @@ static int au1000_open(struct net_device *dev) return retval; } - if (dev->phydev) { - /* cause the PHY state machine to schedule a link state check */ - dev->phydev->state = PHY_CHANGELINK; + if (dev->phydev) phy_start(dev->phydev); - } netif_start_queue(dev); diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index 9b8a30bf939b..810dfc7de1f9 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -991,7 +991,6 @@ static int cpmac_open(struct net_device *dev) cpmac_hw_start(dev); napi_enable(&priv->napi); - dev->phydev->state = PHY_CHANGELINK; phy_start(dev->phydev); return 0; |