aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGaston Gonzalez <gascoar@gmail.com>2021-09-15 17:29:15 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-09-17 16:27:50 +0200
commit341975886aed47b1d34d04676c82f52614a7ba3c (patch)
tree49004606846088615e0bcc5a8b71384d350b471c
parentstaging: vchiq: remove braces from if block (diff)
downloadlinux-dev-341975886aed47b1d34d04676c82f52614a7ba3c.tar.xz
linux-dev-341975886aed47b1d34d04676c82f52614a7ba3c.zip
staging: vchiq: add braces to if block
The rule of not using braces in single statement does not apply if only one branch of the conditional statement is a single statement. Add braces to fix this. While at it, remove extra blank space after a comment inside the if block. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> Link: https://lore.kernel.org/r/20210915202916.413914-2-gascoar@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
index f367dbe2bc63..1802fd5e4888 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
@@ -34,16 +34,15 @@ void vchiq_add_connected_callback(void (*callback)(void))
if (mutex_lock_killable(&g_connected_mutex))
return;
- if (g_connected)
+ if (g_connected) {
/* We're already connected. Call the callback immediately. */
-
callback();
- else {
- if (g_num_deferred_callbacks >= MAX_CALLBACKS)
+ } else {
+ if (g_num_deferred_callbacks >= MAX_CALLBACKS) {
vchiq_log_error(vchiq_core_log_level,
"There already %d callback registered - please increase MAX_CALLBACKS",
g_num_deferred_callbacks);
- else {
+ } else {
g_deferred_callback[g_num_deferred_callbacks] =
callback;
g_num_deferred_callbacks++;