diff options
| author |   Minghao Chi <chi.minghao@zte.com.cn> | 2022-04-13 09:35:02 +0000 |
|---|---|---|
| committer |   Kalle Valo <kvalo@kernel.org> | 2022-04-23 10:11:34 +0300 |
| commit | 3447eebe6084f3d0919e72eafa1b7d19e3f87580 (patch) | |
| tree | f1aa68b22f2c6e57db3d8803f38b3c6cf892a251 | |
| parent | wlcore: sysfs: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() (diff) | |
| download | linux-dev-3447eebe6084f3d0919e72eafa1b7d19e3f87580.tar.xz linux-dev-3447eebe6084f3d0919e72eafa1b7d19e3f87580.zip | |
wlcore: testmode: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
Using pm_runtime_resume_and_get is more appropriate
for simplifing code
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220413093502.2538316-1-chi.minghao@zte.com.cn
| -rw-r--r-- | drivers/net/wireless/ti/wlcore/testmode.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/net/wireless/ti/wlcore/testmode.c b/drivers/net/wireless/ti/wlcore/testmode.c index 3a17b9a8207e..3f338b8096c7 100644 --- a/drivers/net/wireless/ti/wlcore/testmode.c +++ b/drivers/net/wireless/ti/wlcore/testmode.c @@ -83,11 +83,9 @@ static int wl1271_tm_cmd_test(struct wl1271 *wl, struct nlattr *tb[]) goto out; } - ret = pm_runtime_get_sync(wl->dev); - if (ret < 0) { - pm_runtime_put_noidle(wl->dev); + ret = pm_runtime_resume_and_get(wl->dev); + if (ret < 0) goto out; - } ret = wl1271_cmd_test(wl, buf, buf_len, answer); if (ret < 0) { @@ -158,11 +156,9 @@ static int wl1271_tm_cmd_interrogate(struct wl1271 *wl, struct nlattr *tb[]) goto out; } - ret = pm_runtime_get_sync(wl->dev); - if (ret < 0) { - pm_runtime_put_noidle(wl->dev); + ret = pm_runtime_resume_and_get(wl->dev); + if (ret < 0) goto out; - } cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); if (!cmd) { |