diff options
| author |   John Allen <jallen@linux.ibm.com> | 2018-07-16 10:29:30 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-07-16 14:39:47 -0700 |
| commit | 3578a7ecb69920efc3885dbd610e98c00dbdf5db (patch) | |
| tree | 8abcf8f5a7d0ca729b6b28e77ce0f4a8d5d5e78f | |
| parent | net: lan78xx: Fix race in tx pending skb size calculation (diff) | |
| download | linux-dev-3578a7ecb69920efc3885dbd610e98c00dbdf5db.tar.xz linux-dev-3578a7ecb69920efc3885dbd610e98c00dbdf5db.zip | |
ibmvnic: Fix error recovery on login failure
Testing has uncovered a failure case that is not handled properly. In the
event that a login fails and we are not able to recover on the spot, we
return 0 from do_reset, preventing any error recovery code from being
triggered. Additionally, the state is set to "probed" meaning that when we
are able to trigger the error recovery, the driver always comes up in the
probed state. To handle the case properly, we need to return a failure code
here and set the adapter state to the state that we entered the reset in
indicating the state that we would like to come out of the recovery reset
in.
Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/ibm/ibmvnic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index c50963680f30..ffe7acbeaa22 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1827,8 +1827,8 @@ static int do_reset(struct ibmvnic_adapter *adapter, rc = ibmvnic_login(netdev); if (rc) { - adapter->state = VNIC_PROBED; - return 0; + adapter->state = reset_state; + return rc; } if (adapter->reset_reason == VNIC_RESET_CHANGE_PARAM || |