diff options
| author |   Li RongQing <lirongqing@baidu.com> | 2019-02-22 16:58:44 +0800 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2019-02-27 11:03:59 +0100 |
| commit | 35acfbab6e5b229ea3c4807d1949c3ab8fda9818 (patch) | |
| tree | 42b83584943b61c360987bf0db6dfd7a89e049f6 | |
| parent | netfilter: conntrack: avoid same-timeout update (diff) | |
| download | linux-dev-35acfbab6e5b229ea3c4807d1949c3ab8fda9818.tar.xz linux-dev-35acfbab6e5b229ea3c4807d1949c3ab8fda9818.zip | |
netfilter: remove unneeded switch fall-through
Empty case is fine and does not switch fall-through
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | net/netfilter/nf_nat_core.c | 2 | ||||
| -rw-r--r-- | net/netfilter/nf_tables_core.c | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c index 11acd7367623..af7dc6537758 100644 --- a/net/netfilter/nf_nat_core.c +++ b/net/netfilter/nf_nat_core.c @@ -240,7 +240,7 @@ static bool l4proto_in_range(const struct nf_conntrack_tuple *tuple, __be16 port; switch (tuple->dst.protonum) { - case IPPROTO_ICMP: /* fallthrough */ + case IPPROTO_ICMP: case IPPROTO_ICMPV6: return ntohs(tuple->src.u.icmp.id) >= ntohs(min->icmp.id) && ntohs(tuple->src.u.icmp.id) <= ntohs(max->icmp.id); diff --git a/net/netfilter/nf_tables_core.c b/net/netfilter/nf_tables_core.c index 2a00aef7b6d4..e56a94dff34e 100644 --- a/net/netfilter/nf_tables_core.c +++ b/net/netfilter/nf_tables_core.c @@ -221,7 +221,6 @@ next_rule: chain = regs.verdict.chain; goto do_chain; case NFT_CONTINUE: - /* fall through */ case NFT_RETURN: nft_trace_packet(&info, chain, rule, NFT_TRACETYPE_RETURN); |