aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHaowen Bai <baihaowen@meizu.com>2022-03-28 10:05:03 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2022-04-25 23:29:40 -0400
commit391b8dac55770686d33f65ab5e87cfbc5bb3942d (patch)
tree792dee9b30930b8c45c46a06a16d96d973b0202d
parentscsi: elx: efct: Remove unnecessary memset() in efct_io() (diff)
downloadlinux-dev-391b8dac55770686d33f65ab5e87cfbc5bb3942d.tar.xz
linux-dev-391b8dac55770686d33f65ab5e87cfbc5bb3942d.zip
scsi: ipr: Directly return instead of using local ret variable
Fixes coccinelle warning: ./drivers/scsi/ipr.c:10095:13-15: Unneeded variable: "rc". Return "IRQ_HANDLED" on line 10104 Link: https://lore.kernel.org/r/1648433103-24308-1-git-send-email-baihaowen@meizu.com Signed-off-by: Haowen Bai <baihaowen@meizu.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/ipr.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 104bee9b3a9d..353cf47db79c 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -10092,7 +10092,6 @@ static irqreturn_t ipr_test_intr(int irq, void *devp)
{
struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)devp;
unsigned long lock_flags = 0;
- irqreturn_t rc = IRQ_HANDLED;
dev_info(&ioa_cfg->pdev->dev, "Received IRQ : %d\n", irq);
spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
@@ -10101,7 +10100,7 @@ static irqreturn_t ipr_test_intr(int irq, void *devp)
wake_up(&ioa_cfg->msi_wait_q);
spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
- return rc;
+ return IRQ_HANDLED;
}
/**