aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Rose <gregory.v.rose@intel.com>2012-09-25 02:25:30 +0000
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2012-10-29 22:32:07 -0700
commit3970c3234bbaac962a6c9213536dfcabc421d0d0 (patch)
tree1f7ef755b91291612e5c2d3867a88cae1fd6506c
parentixgbe: clean up the condition for turning on/off the laser (diff)
downloadlinux-dev-3970c3234bbaac962a6c9213536dfcabc421d0d0.tar.xz
linux-dev-3970c3234bbaac962a6c9213536dfcabc421d0d0.zip
ixgbe: Return success or failure on VF MAC filter set
When setting a MAC filter for the VF the function should return a success or failure code, not the index of the new filter. It causes spurious NACK returns to the VF driver. Signed-off-by: Greg Rose <gregory.v.rose@intel.com> Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com> Tested-by: Sibai Li <sibai.li@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r--drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 8bdb341c14bf..bfeb7ec2abd9 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -675,7 +675,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter *adapter,
return -1;
}
- return ixgbe_set_vf_mac(adapter, vf, new_mac);
+ return ixgbe_set_vf_mac(adapter, vf, new_mac) < 0;
}
static int ixgbe_set_vf_vlan_msg(struct ixgbe_adapter *adapter,