diff options
| author |   Christian Lamparter <chunkeey@googlemail.com> | 2011-01-06 23:47:52 +0100 |
|---|---|---|
| committer |   John W. Linville <linville@tuxdriver.com> | 2011-01-10 15:40:53 -0500 |
| commit | 3b5c5827d1f80ad8ae844a8b1183f59ddb90fe25 (patch) | |
| tree | 925d555241da1d54e427a603772f71f9251c1d9b | |
| parent | mac80211: add doc short section on LED triggers (diff) | |
| download | linux-dev-3b5c5827d1f80ad8ae844a8b1183f59ddb90fe25.tar.xz linux-dev-3b5c5827d1f80ad8ae844a8b1183f59ddb90fe25.zip | |
p54: fix sequence no. accounting off-by-one error
P54_HDR_FLAG_DATA_OUT_SEQNR is meant to tell the
firmware that "the frame's sequence number has
already been set by the application."
Whereas IEEE80211_TX_CTL_ASSIGN_SEQ is set for
frames which lack a valid sequence number and
either the driver or firmware has to assign one.
Yup, it's the exact opposite!
Cc: <stable@kernel.org>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| -rw-r--r-- | drivers/net/wireless/p54/txrx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/p54/txrx.c b/drivers/net/wireless/p54/txrx.c index 76b2318a7dc7..f618b9623e5a 100644 --- a/drivers/net/wireless/p54/txrx.c +++ b/drivers/net/wireless/p54/txrx.c @@ -618,7 +618,7 @@ static void p54_tx_80211_header(struct p54_common *priv, struct sk_buff *skb, else *burst_possible = false; - if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) + if (!(info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)) *flags |= P54_HDR_FLAG_DATA_OUT_SEQNR; if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE) |