diff options
| author |   Maxime Chevallier <maxime.chevallier@bootlin.com> | 2019-05-23 10:47:24 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-23 09:13:00 -0700 |
| commit | 3f6f7a175ad4cf9a6a3dda72d7f5d122107f4b9e (patch) | |
| tree | 55f3e4df7882e345f46b09dd64505df923b7a005 | |
| parent | ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST (diff) | |
| download | linux-dev-3f6f7a175ad4cf9a6a3dda72d7f5d122107f4b9e.tar.xz linux-dev-3f6f7a175ad4cf9a6a3dda72d7f5d122107f4b9e.zip | |
net: mvpp2: cls: Fix leaked ethtool_rx_flow_rule
The flow_rule is only used when configuring the classification tables,
and should be free'd once we're done using it. The current code only
frees it in the error path.
Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c index d046f7a1dcf5..a57d17ab91f0 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c @@ -1271,6 +1271,9 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port, if (ret) goto clean_eth_rule; + ethtool_rx_flow_rule_destroy(ethtool_rule); + efs->rule.flow = NULL; + memcpy(&efs->rxnfc, info, sizeof(*info)); port->rfs_rules[efs->rule.loc] = efs; port->n_rfs_rules++; |