diff options
| author |   Tobias Waldekranz <tobias@waldekranz.com> | 2022-01-18 22:50:53 +0100 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-01-19 08:14:18 -0800 |
| commit | 3f7c239c7844d2044ed399399d97a5f1c6008e1b (patch) | |
| tree | 783e98169a5fc339f7f3ec409cf495c01a4cf0de | |
| parent | powerpc/fsl/dts: Enable WA for erratum A-009885 on fman3l MDIO buses (diff) | |
| download | linux-dev-3f7c239c7844d2044ed399399d97a5f1c6008e1b.tar.xz linux-dev-3f7c239c7844d2044ed399399d97a5f1c6008e1b.zip | |
net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module
As reported by sparse: In the remove path, the driver would attempt to
unmap its own priv pointer - instead of the io memory that it mapped
in probe.
Fixes: 9f35a7342cff ("net/fsl: introduce Freescale 10G MDIO driver")
Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/freescale/xgmac_mdio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index bf566ac3195b..266e562bd67a 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -331,9 +331,10 @@ err_ioremap: static int xgmac_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct mdio_fsl_priv *priv = bus->priv; mdiobus_unregister(bus); - iounmap(bus->priv); + iounmap(priv->mdio_base); mdiobus_free(bus); return 0; |