diff options
| author |   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2013-12-20 01:41:12 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-12-19 19:09:38 -0500 |
| commit | 4174ecd78f6591a3d1ec04738ef7bc900a11f5ce (patch) | |
| tree | d1e30f9d0941602c58e71bb17f4ab39c67650f88 | |
| parent | sh_eth: add PHY IRQ to platform data (diff) | |
| download | linux-dev-4174ecd78f6591a3d1ec04738ef7bc900a11f5ce.tar.xz linux-dev-4174ecd78f6591a3d1ec04738ef7bc900a11f5ce.zip | |
sh_eth: do not reset PHY needlessly
There's no need anymore to call phy_init_hw() to reset/resume the PHY from the
driver, as the call chain in phylib already has reached it, and so reset/resumed
the PHY (even resuming it twice). This duplicate reset is not only needless, it
e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the
expected IRQs from the PHY.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 9d8013f82019..ca742e1f704e 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_device *ndev) if (ret) return ret; - /* reset phy - this also wakes it from PDOWN */ - ret = phy_init_hw(mdp->phydev); - if (ret) - return ret; - phy_start(mdp->phydev); return 0; |