diff options
| author |   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2022-09-05 23:17:43 +0000 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-09-07 12:44:30 +0100 |
| commit | 427de091a7112aa8eaf2f689e95c0dbca5ea6543 (patch) | |
| tree | 8df130985230c3a8b086e2964c6e22fa555fca62 | |
| parent | lib/string_helpers: Introduce parse_int_array_user() (diff) | |
| download | linux-dev-427de091a7112aa8eaf2f689e95c0dbca5ea6543.tar.xz linux-dev-427de091a7112aa8eaf2f689e95c0dbca5ea6543.zip | |
ASoC: soc-dapm.c: don't use WARN_ON() at snd_soc_dai_link_event_pre_pmu()
Current snd_soc_dai_link_event_pre_pmu() is checking "config".
It is using dev_err() (A) if it was NULL, so we don't need to use
WARN_ON() (B) to check it, it is over-kill. This patch removes it.
(B) if (WARN_ON(!config)) {
(A) dev_err(...);
...
}
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87zgfd8l7s.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/soc-dapm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 73b8bd452ca7..02924395ed86 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3885,7 +3885,7 @@ snd_soc_dai_link_event_pre_pmu(struct snd_soc_dapm_widget *w, * necessary */ config = rtd->dai_link->params + rtd->params_select; - if (WARN_ON(!config)) { + if (!config) { dev_err(w->dapm->dev, "ASoC: link config missing\n"); ret = -EINVAL; goto out; |