diff options
| author |   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2017-12-31 21:41:36 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-01-03 10:21:35 -0500 |
| commit | 4282fc47c01262fdda55a9d63a4e25173fd9afb4 (patch) | |
| tree | af2fd522bbc6d9d22f7d34de40fdd1efeca5473c | |
| parent | ravb: kill redundant check in the probe() method (diff) | |
| download | linux-dev-4282fc47c01262fdda55a9d63a4e25173fd9afb4.tar.xz linux-dev-4282fc47c01262fdda55a9d63a4e25173fd9afb4.zip | |
sh_eth: kill redundant check in the probe() method
Browsing thru the driver disassembly, I noticed that gcc was able to
figure out that the 'ndev' pointer is always non-NULL when calling
free_netdev() on the probe() method's error path and thus skip that
redundant NULL check... gcc is smart, be like gcc! :-)
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 75323000c364..d47bbbb22e7c 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3282,8 +3282,7 @@ out_napi_del: out_release: /* net_dev free */ - if (ndev) - free_netdev(ndev); + free_netdev(ndev); pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); |