diff options
| author |   Gustavo A. R. Silva <gustavoars@kernel.org> | 2022-01-25 11:52:45 -0600 |
|---|---|---|
| committer |   Sebastian Reichel <sebastian.reichel@collabora.com> | 2022-01-31 22:42:25 +0100 |
| commit | 441d38c60fbe5b416e562853aa3041c7dcaf3af7 (patch) | |
| tree | d644284640f3fe3efc0f89fe1f9e1b6d855db936 | |
| parent | Linux 5.17-rc1 (diff) | |
| download | linux-dev-441d38c60fbe5b416e562853aa3041c7dcaf3af7.tar.xz linux-dev-441d38c60fbe5b416e562853aa3041c7dcaf3af7.zip | |
power: supply: cros_usbpd: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:
drivers/power/supply/cros_usbpd-charger.c:107:23: warning: using sizeof on a flexible structure
Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
| -rw-r--r-- | drivers/power/supply/cros_usbpd-charger.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/cros_usbpd-charger.c b/drivers/power/supply/cros_usbpd-charger.c index d89e08efd2ad..cadb6a0c2cc7 100644 --- a/drivers/power/supply/cros_usbpd-charger.c +++ b/drivers/power/supply/cros_usbpd-charger.c @@ -104,7 +104,7 @@ static int cros_usbpd_charger_ec_command(struct charger_data *charger, struct cros_ec_command *msg; int ret; - msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL); + msg = kzalloc(struct_size(msg, data, max(outsize, insize)), GFP_KERNEL); if (!msg) return -ENOMEM; |