diff options
| author |   Anand Jain <anand.jain@oracle.com> | 2019-04-20 19:48:57 +0800 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2019-04-29 19:02:53 +0200 |
| commit | 44e5194b5ec1b179c59bb204a2448031ff917e02 (patch) | |
| tree | a227e5d531d4bae47e3b8dd0505890add47368d3 | |
| parent | btrfs: drop old_fsflags in btrfs_ioctl_setflags (diff) | |
| download | linux-dev-44e5194b5ec1b179c59bb204a2448031ff917e02.tar.xz linux-dev-44e5194b5ec1b179c59bb204a2448031ff917e02.zip | |
btrfs: drop local copy of inode i_mode
There isn't real use of making struct inode::i_mode a local copy, it
saves a dereference one time, not much. Just use it directly.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/ioctl.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index d459c37578ea..6dafa857bbb9 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -189,7 +189,6 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) struct btrfs_trans_handle *trans; unsigned int fsflags; int ret; - umode_t mode; const char *comp = NULL; u32 binode_flags = binode->flags; @@ -212,8 +211,6 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) inode_lock(inode); - mode = inode->i_mode; - fsflags = btrfs_mask_fsflags_for_type(inode, fsflags); if ((fsflags ^ btrfs_inode_flags_to_fsflags(binode->flags)) & (FS_APPEND_FL | FS_IMMUTABLE_FL)) { @@ -248,7 +245,7 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) else binode_flags &= ~BTRFS_INODE_DIRSYNC; if (fsflags & FS_NOCOW_FL) { - if (S_ISREG(mode)) { + if (S_ISREG(inode->i_mode)) { /* * It's safe to turn csums off here, no extents exist. * Otherwise we want the flag to reflect the real COW @@ -264,7 +261,7 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) /* * Revert back under same assumptions as above */ - if (S_ISREG(mode)) { + if (S_ISREG(inode->i_mode)) { if (inode->i_size == 0) binode_flags &= ~(BTRFS_INODE_NODATACOW | BTRFS_INODE_NODATASUM); |