aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 15:39:05 +0100
committerGreg Ungerer <gerg@uclinux.org>2016-01-04 13:25:12 +1000
commit4693c2493a9b2d0c5d407496ea107676a690f1c0 (patch)
tree642bf9ac60b509b343b21565e313a00a314abe50
parentLinux 4.4-rc8 (diff)
downloadlinux-dev-4693c2493a9b2d0c5d407496ea107676a690f1c0.tar.xz
linux-dev-4693c2493a9b2d0c5d407496ea107676a690f1c0.zip
m68k: coldfire/gpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
-rw-r--r--arch/m68k/coldfire/gpio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
index e7e428681ec5..37a83e27c7a6 100644
--- a/arch/m68k/coldfire/gpio.c
+++ b/arch/m68k/coldfire/gpio.c
@@ -121,7 +121,7 @@ static int mcfgpio_direction_input(struct gpio_chip *chip, unsigned offset)
static int mcfgpio_get_value(struct gpio_chip *chip, unsigned offset)
{
- return __mcfgpio_get_value(offset);
+ return !!__mcfgpio_get_value(offset);
}
static int mcfgpio_direction_output(struct gpio_chip *chip, unsigned offset,