aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorH Hartley Sweeten <hsweeten@visionengravers.com>2015-10-06 17:23:39 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-10-12 22:56:26 -0700
commit46ada8afc8fdd2788db152ceb0fc001f46072dfe (patch)
tree60e843a33c84af78266acc902747ab786bc066a4
parentstaging: comedi: me_daq: tidy up dac control register defines (diff)
staging: comedi: me_daq: remove useless for() loop
This for() loop isn't needed. Nothing in the loop uses the 'i' variable. Remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/comedi/drivers/me_daq.c15
1 files changed, 6 insertions, 9 deletions
diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c
index 71188fbadb65..a2b542ef8fd5 100644
--- a/drivers/staging/comedi/drivers/me_daq.c
+++ b/drivers/staging/comedi/drivers/me_daq.c
@@ -319,15 +319,12 @@ static int me_ao_insn_write(struct comedi_device *dev,
writew(devpriv->ctrl2, dev->mmio + ME_CTRL2_REG);
/* Set dac-control register */
- for (i = 0; i < insn->n; i++) {
- /* clear bits for this channel */
- devpriv->dac_ctrl &= ~ME_DAC_CTRL_MASK(chan);
- if (range == 0)
- devpriv->dac_ctrl |= ME_DAC_CTRL_GAIN(chan) |
- ME_DAC_CTRL_BIPOLAR(chan);
- else if (range == 1)
- devpriv->dac_ctrl |= ME_DAC_CTRL_BIPOLAR(chan);
- }
+ devpriv->dac_ctrl &= ~ME_DAC_CTRL_MASK(chan);
+ if (range == 0)
+ devpriv->dac_ctrl |= ME_DAC_CTRL_GAIN(chan) |
+ ME_DAC_CTRL_BIPOLAR(chan);
+ else if (range == 1)
+ devpriv->dac_ctrl |= ME_DAC_CTRL_BIPOLAR(chan);
writew(devpriv->dac_ctrl, dev->mmio + ME_DAC_CTRL_REG);
/* Update dac-control register */