aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBart Van Assche <bart.vanassche@wdc.com>2017-08-23 10:56:30 -0700
committerJens Axboe <axboe@kernel.dk>2017-08-23 12:02:32 -0600
commit49f16e2f20432a452e47454710fbb25b34f8681b (patch)
treeac2a74abeec25a0ec05b02aa40059741c754d99a
parentblock: Warn if blk_queue_rq_timed_out() is called for a blk-mq queue (diff)
downloadlinux-dev-49f16e2f20432a452e47454710fbb25b34f8681b.tar.xz
linux-dev-49f16e2f20432a452e47454710fbb25b34f8681b.zip
skd: Report completion mismatches once
This patch removes one debug statement but otherwise does not change any functionality. Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Cc: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--drivers/block/skd_main.c14
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index a467c18cc047..d21fc76c5ed9 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1564,17 +1564,11 @@ static int skd_isr_completion_posted(struct skd_device *skdev,
* Make sure the request ID for the slot matches.
*/
if (skreq->id != req_id) {
- dev_dbg(&skdev->pdev->dev,
- "mismatch comp_id=0x%x req_id=0x%x\n", req_id,
- skreq->id);
- {
- u16 new_id = cmp_cntxt;
- dev_err(&skdev->pdev->dev,
- "Completion mismatch comp_id=0x%04x skreq=0x%04x new=0x%04x\n",
- req_id, skreq->id, new_id);
+ dev_err(&skdev->pdev->dev,
+ "Completion mismatch comp_id=0x%04x skreq=0x%04x new=0x%04x\n",
+ req_id, skreq->id, cmp_cntxt);
- continue;
- }
+ continue;
}
SKD_ASSERT(skreq->state == SKD_REQ_STATE_BUSY);