diff options
| author |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-12-13 18:26:10 +0100 |
|---|---|---|
| committer |   Gerd Hoffmann <kraxel@redhat.com> | 2019-12-16 12:39:50 +0100 |
| commit | 4ad7056a4014e1cbc77f7b0361398fa26d2817b1 (patch) | |
| tree | 74e0418481ecd7ac471a7a52ec556d670b1d0db6 | |
| parent | drm/bochs: Remove unneeded semicolon (diff) | |
| download | linux-dev-4ad7056a4014e1cbc77f7b0361398fa26d2817b1.tar.xz linux-dev-4ad7056a4014e1cbc77f7b0361398fa26d2817b1.zip | |
drm/virtio: plane_state->fb iff plane_state->crtc
Checking both is one too much, so wrap a WARN_ON around it to stope
the copypasta.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20191213172612.1514842-8-daniel.vetter@ffwll.ch
Cc: David Airlie <airlied@linux.ie>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/virtio/virtgpu_plane.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index bc4bc4475a8c..947e65b51555 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -88,7 +88,7 @@ static int virtio_gpu_plane_atomic_check(struct drm_plane *plane, struct drm_crtc_state *crtc_state; int ret; - if (!state->fb || !state->crtc) + if (!state->fb || WARN_ON(!state->crtc)) return 0; crtc_state = drm_atomic_get_crtc_state(state->state, state->crtc); |