diff options
| author |   Kumar Kartikeya Dwivedi <memxor@gmail.com> | 2021-06-12 08:05:00 +0530 |
|---|---|---|
| committer |   Daniel Borkmann <daniel@iogearbox.net> | 2021-06-15 13:58:56 +0200 |
| commit | 4e164f8716853b879e2b1a21a12d54c57f11372e (patch) | |
| tree | 8f65ce38c4e41fdbcbbb5b4fb25d7ac36518243a | |
| parent | tools/bpftool: Fix error return code in do_batch() (diff) | |
| download | linux-dev-4e164f8716853b879e2b1a21a12d54c57f11372e.tar.xz linux-dev-4e164f8716853b879e2b1a21a12d54c57f11372e.zip | |
libbpf: Remove unneeded check for flags during tc detach
Coverity complained about this being unreachable code. It is right
because we already enforce flags to be unset, so a check validating
the flag value is redundant.
Fixes: 715c5ce454a6 ("libbpf: Add low level TC-BPF management API")
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210612023502.1283837-2-memxor@gmail.com
| -rw-r--r-- | tools/lib/bpf/netlink.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/tools/lib/bpf/netlink.c b/tools/lib/bpf/netlink.c index d743c8721aa7..efbb50ad59d8 100644 --- a/tools/lib/bpf/netlink.c +++ b/tools/lib/bpf/netlink.c @@ -675,8 +675,6 @@ static int __bpf_tc_detach(const struct bpf_tc_hook *hook, return -EINVAL; if (priority > UINT16_MAX) return -EINVAL; - if (flags & ~BPF_TC_F_REPLACE) - return -EINVAL; if (!flush) { if (!handle || !priority) return -EINVAL; |