diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2022-01-28 16:52:38 +0000 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-02-08 13:40:19 +0000 |
| commit | 4f92724d4b92c024e721063f520d66e11ca4b54b (patch) | |
| tree | 035ab09e19a3c416e8f81b79b910fe55414349b3 | |
| parent | spi: ath79: add mem_ops for fast-read (diff) | |
| download | linux-dev-4f92724d4b92c024e721063f520d66e11ca4b54b.tar.xz linux-dev-4f92724d4b92c024e721063f520d66e11ca4b54b.zip | |
spi: tegra114: Add missing IRQ check in tegra_spi_probe
This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.
Fixes: f333a331adfa ("spi/tegra114: add spi driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165238.25615-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-tegra114.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index e9de1d958bbd..8f345247a8c3 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -1352,6 +1352,10 @@ static int tegra_spi_probe(struct platform_device *pdev) tspi->phys = r->start; spi_irq = platform_get_irq(pdev, 0); + if (spi_irq < 0) { + ret = spi_irq; + goto exit_free_master; + } tspi->irq = spi_irq; tspi->clk = devm_clk_get(&pdev->dev, "spi"); |