diff options
| author |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-04-17 13:51:55 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-04-18 17:06:15 -0700 |
| commit | 503c01880166d4afb77d6059f3128a156190b88d (patch) | |
| tree | 7e8a384347575614f886593c66245f2862625db5 | |
| parent | ipv6: Add rate limit mask for ICMPv6 messages (diff) | |
| download | linux-dev-503c01880166d4afb77d6059f3128a156190b88d.tar.xz linux-dev-503c01880166d4afb77d6059f3128a156190b88d.zip | |
l2tp: fix set but not used variable
GCC complains:
net/l2tp/l2tp_ppp.c: In function ‘pppol2tp_ioctl’:
net/l2tp/l2tp_ppp.c:1073:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]
int val;
^~~
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/l2tp/l2tp_ppp.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index 04d9946dcdba..f36cae785e82 100644 --- a/net/l2tp/l2tp_ppp.c +++ b/net/l2tp/l2tp_ppp.c @@ -1070,7 +1070,6 @@ static int pppol2tp_ioctl(struct socket *sock, unsigned int cmd, { struct pppol2tp_ioc_stats stats; struct l2tp_session *session; - int val; switch (cmd) { case PPPIOCGMRU: @@ -1097,7 +1096,7 @@ static int pppol2tp_ioctl(struct socket *sock, unsigned int cmd, if (!session->session_id && !session->peer_session_id) return -ENOSYS; - if (get_user(val, (int __user *)arg)) + if (!access_ok((int __user *)arg, sizeof(int))) return -EFAULT; break; |