diff options
| author |   Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> | 2019-08-07 01:45:40 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-08 22:00:24 -0700 |
| commit | 51650d33b2771acd505068da669cf85cffac369a (patch) | |
| tree | f974e43343186b5e7e39f066a56ac81ef3fa6f5d | |
| parent | net: docs: replace IPX in tuntap documentation (diff) | |
| download | linux-dev-51650d33b2771acd505068da669cf85cffac369a.tar.xz linux-dev-51650d33b2771acd505068da669cf85cffac369a.zip | |
net: sched: sch_taprio: fix memleak in error path for sched list parse
In error case, all entries should be freed from the sched list
before deleting it. For simplicity use rcu way.
Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler")
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/sch_taprio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index c39db507ba3f..e25d414ae12f 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -1195,7 +1195,8 @@ unlock: spin_unlock_bh(qdisc_lock(sch)); free_sched: - kfree(new_admin); + if (new_admin) + call_rcu(&new_admin->rcu, taprio_free_sched_cb); return err; } |