aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-11-04 20:00:42 +0100
committerRichard Weinberger <richard@nod.at>2015-11-06 23:26:52 +0100
commit54bcfdf19ec7c2f2788fa76426c91abdc4dab973 (patch)
tree71f95afe9a00c706ceb563f1d2c9089ec433c201
parentUBI: Remove in vain semicolon (diff)
downloadlinux-dev-54bcfdf19ec7c2f2788fa76426c91abdc4dab973.tar.xz
linux-dev-54bcfdf19ec7c2f2788fa76426c91abdc4dab973.zip
UBIFS: Delete unnecessary checks before the function call "iput"
The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Richard Weinberger <richard@nod.at>
-rw-r--r--fs/ubifs/recovery.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 2a1f0bc836be..586d59347fff 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -1331,8 +1331,7 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
struct size_entry *e, *n;
rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
- if (e->inode)
- iput(e->inode);
+ iput(e->inode);
kfree(e);
}
@@ -1533,8 +1532,7 @@ int ubifs_recover_size(struct ubifs_info *c)
err = fix_size_in_place(c, e);
if (err)
return err;
- if (e->inode)
- iput(e->inode);
+ iput(e->inode);
}
}