diff options
| author |   Miklos Szeredi <mszeredi@redhat.com> | 2021-01-28 10:22:48 +0100 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2021-01-28 10:22:48 +0100 |
| commit | 554677b97257b0b69378bd74e521edb7e94769ff (patch) | |
| tree | dda70a39b9d857725fd20f57e1869fba897377fd | |
| parent | ovl: add warning on user_ns mismatch (diff) | |
| download | linux-dev-554677b97257b0b69378bd74e521edb7e94769ff.tar.xz linux-dev-554677b97257b0b69378bd74e521edb7e94769ff.zip | |
ovl: perform vfs_getxattr() with mounter creds
The vfs_getxattr() in ovl_xattr_set() is used to check whether an xattr
exist on a lower layer file that is to be removed. If the xattr does not
exist, then no need to copy up the file.
This call of vfs_getxattr() wasn't wrapped in credential override, and this
is probably okay. But for consitency wrap this instance as well.
Reported-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
| -rw-r--r-- | fs/overlayfs/inode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index d739e14c6814..cf41bcb664bc 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -352,7 +352,9 @@ int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name, goto out; if (!value && !upperdentry) { + old_cred = ovl_override_creds(dentry->d_sb); err = vfs_getxattr(realdentry, name, NULL, 0); + revert_creds(old_cred); if (err < 0) goto out_drop_write; } |