diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-08-20 17:37:55 +0200 |
|---|---|---|
| committer |   Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2021-08-31 12:09:53 +0200 |
| commit | 555bda42b0c1a5ffb72d3227c043e8afde778f1f (patch) | |
| tree | 84f98245098a6211ea1961b898eae5abe07b5b14 | |
| parent | gpio: viperboard: remove platform_set_drvdata() call in probe (diff) | |
| download | linux-dev-555bda42b0c1a5ffb72d3227c043e8afde778f1f.tar.xz linux-dev-555bda42b0c1a5ffb72d3227c043e8afde778f1f.zip | |
gpio: mpc8xxx: Fix a resources leak in the error handling path of 'mpc8xxx_probe()'
Commit 698b8eeaed72 ("gpio/mpc8xxx: change irq handler from chained to normal")
has introduced a new 'goto err;' at the very end of the function, but has
not updated the error handling path accordingly.
Add the now missing 'irq_domain_remove()' call which balances a previous
'irq_domain_create_linear() call.
Fixes: 698b8eeaed72 ("gpio/mpc8xxx: change irq handler from chained to normal")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
| -rw-r--r-- | drivers/gpio/gpio-mpc8xxx.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index 4b9157a69fca..b5cbeca5e300 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -416,6 +416,8 @@ static int mpc8xxx_probe(struct platform_device *pdev) return 0; err: + if (mpc8xxx_gc->irq) + irq_domain_remove(mpc8xxx_gc->irq); iounmap(mpc8xxx_gc->regs); return ret; } |