diff options
| author |   Vasundhara Volam <vasundhara-v.volam@broadcom.com> | 2020-02-20 17:26:34 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-20 16:05:42 -0800 |
| commit | 5567ae4a8d569d996d0d88d0eceb76205e4c7ce5 (patch) | |
| tree | 782cc6e64aac4e9216cf673489c97f39960c157c | |
| parent | net: netlink: cap max groups which will be considered in netlink_bind() (diff) | |
| download | linux-dev-5567ae4a8d569d996d0d88d0eceb76205e4c7ce5.tar.xz linux-dev-5567ae4a8d569d996d0d88d0eceb76205e4c7ce5.zip | |
bnxt_en: Improve device shutdown method.
Especially when bnxt_shutdown() is called during kexec, we need to
disable MSIX and disable Bus Master to completely quiesce the device.
Make these 2 calls unconditionally in the shutdown method.
Fixes: c20dc142dd7b ("bnxt_en: Disable bus master during PCI shutdown and driver unload.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 597e6fd5bfea..2ad007e5ee7f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -11983,10 +11983,10 @@ static void bnxt_shutdown(struct pci_dev *pdev) dev_close(dev); bnxt_ulp_shutdown(bp); + bnxt_clear_int_mode(bp); + pci_disable_device(pdev); if (system_state == SYSTEM_POWER_OFF) { - bnxt_clear_int_mode(bp); - pci_disable_device(pdev); pci_wake_from_d3(pdev, bp->wol); pci_set_power_state(pdev, PCI_D3hot); } |