diff options
| author |   Shuah Khan (Samsung OSG) <shuah@kernel.org> | 2018-05-03 17:09:40 -0600 |
|---|---|---|
| committer | Shuah Khan (Samsung OSG) <shuah@kernel.org> | 2018-05-30 15:21:53 -0600 |
| commit | 5c30a038fb8ec8cdff011e6b5d5d51eb415381d4 (patch) | |
| tree | 353463762781d60a1ff06664e75e6344084eb2e9 | |
| parent | selftests: gpio: return Kselftest Skip code for skipped tests (diff) | |
| download | linux-dev-5c30a038fb8ec8cdff011e6b5d5d51eb415381d4.tar.xz linux-dev-5c30a038fb8ec8cdff011e6b5d5d51eb415381d4.zip | |
selftests: intel_pstate: return Kselftest Skip code for skipped tests
When intel_pstate test is skipped because of unmet dependencies and/or
unsupported configuration, it returns 0 which is treated as a pass
by the Kselftest framework. This leads to false positive result even
when the test could not be run.
Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.
Kselftest framework SKIP code is 4 and the framework prints appropriate
messages to indicate that the test is skipped.
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
| -rwxr-xr-x | tools/testing/selftests/intel_pstate/run.sh | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh index c670359becc6..6ded61670f6d 100755 --- a/tools/testing/selftests/intel_pstate/run.sh +++ b/tools/testing/selftests/intel_pstate/run.sh @@ -30,9 +30,12 @@ EVALUATE_ONLY=0 +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then echo "$0 # Skipped: Test can only run on x86 architectures." - exit 0 + exit $ksft_skip fi max_cpus=$(($(nproc)-1)) |