diff options
| author |   Alexander Couzens <lynxis@fe80.eu> | 2018-07-17 13:17:09 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-07-18 13:43:16 -0700 |
| commit | 5c968f48021a9b3faa61ac2543cfab32461c0e05 (patch) | |
| tree | 1225823c2a44aaddaf6f0532b9c3a66ee2bafe8a | |
| parent | net: cxgb3_main: fix potential Spectre v1 (diff) | |
| download | linux-dev-5c968f48021a9b3faa61ac2543cfab32461c0e05.tar.xz linux-dev-5c968f48021a9b3faa61ac2543cfab32461c0e05.zip | |
net: usb: asix: replace mii_nway_restart in resume path
mii_nway_restart is not pm aware which results in a rtnl deadlock.
Implement mii_nway_restart manual by setting BMCR_ANRESTART if
BMCR_ANENABLE is set.
To reproduce:
* plug an asix based usb network interface
* wait until the device enters PM (~5 sec)
* `ip link set eth1 up` will never return
Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter")
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/asix_devices.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 3d4f7959dabb..b1b3d8f7e67d 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -642,10 +642,12 @@ static void ax88772_restore_phy(struct usbnet *dev) priv->presvd_phy_advertise); /* Restore BMCR */ + if (priv->presvd_phy_bmcr & BMCR_ANENABLE) + priv->presvd_phy_bmcr |= BMCR_ANRESTART; + asix_mdio_write_nopm(dev->net, dev->mii.phy_id, MII_BMCR, priv->presvd_phy_bmcr); - mii_nway_restart(&dev->mii); priv->presvd_phy_advertise = 0; priv->presvd_phy_bmcr = 0; } |