diff options
| author |   Michal Schmidt <mschmidt@redhat.com> | 2016-03-02 13:47:06 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-02 13:31:55 -0500 |
| commit | 5cc5c2d2e5a46c7395a0453f9ea1a446ac4c1b97 (patch) | |
| tree | 383440799941c8358c4a0633ebb38afa9d3c33f3 | |
| parent | bnx2x: fix crash on big-endian when adding VLAN (diff) | |
| download | linux-dev-5cc5c2d2e5a46c7395a0453f9ea1a446ac4c1b97.tar.xz linux-dev-5cc5c2d2e5a46c7395a0453f9ea1a446ac4c1b97.zip | |
bnx2x: fix sending VF->PF messages on big-endian
When a VF is sending a message to the PF, it needs to trigger the PF
to tell it the message is ready.
The trigger did not work on ppc64. No interrupt appeared in the PF.
The bug is due to confusion about the layout of struct trigger_vf_zone.
In bnx2x_send_msg2pf() the trigger is written using writeb(), not
writel(), so the attempt to define the struct with a reversed layout on
big-endian is counter-productive.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h index 90a4dba3eccf..47b13ed6a01a 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h @@ -5114,15 +5114,9 @@ struct vf_pf_channel_zone_trigger { * zone that triggers the in-bound interrupt */ struct trigger_vf_zone { -#if defined(__BIG_ENDIAN) - u16 reserved1; - u8 reserved0; - struct vf_pf_channel_zone_trigger vf_pf_channel; -#elif defined(__LITTLE_ENDIAN) struct vf_pf_channel_zone_trigger vf_pf_channel; u8 reserved0; u16 reserved1; -#endif u32 reserved2; }; |