diff options
| author |   Bart Van Assche <bvanassche@acm.org> | 2022-05-11 16:51:52 -0700 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2022-05-12 06:33:26 -0600 |
| commit | 5d2ae14276e698c76fa0c8ce870103f343b38263 (patch) | |
| tree | 0f18e3fe0fb4fdb72ccb37340d6a0e8dfe5359c2 | |
| parent | block: reorder the REQ_ flags (diff) | |
| download | linux-dev-5d2ae14276e698c76fa0c8ce870103f343b38263.tar.xz linux-dev-5d2ae14276e698c76fa0c8ce870103f343b38263.zip | |
block: Fix the bio.bi_opf comment
Commit ef295ecf090d modified the Linux kernel such that the bottom bits
of the bi_opf member contain the operation instead of the topmost bits.
That commit did not update the comment next to bi_opf. Hence this patch.
From commit ef295ecf090d:
-#define bio_op(bio) ((bio)->bi_opf >> BIO_OP_SHIFT)
+#define bio_op(bio) ((bio)->bi_opf & REQ_OP_MASK)
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Fixes: ef295ecf090d ("block: better op and flags encoding")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220511235152.1082246-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | include/linux/blk_types.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 30f9a5391fd5..40e815400611 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -246,9 +246,8 @@ typedef unsigned int blk_qc_t; struct bio { struct bio *bi_next; /* request queue link */ struct block_device *bi_bdev; - unsigned int bi_opf; /* bottom bits req flags, - * top bits REQ_OP. Use - * accessors. + unsigned int bi_opf; /* bottom bits REQ_OP, top bits + * req_flags. */ unsigned short bi_flags; /* BIO_* below */ unsigned short bi_ioprio; |