diff options
| author |   Jason Gunthorpe <jgg@nvidia.com> | 2020-08-25 13:35:38 -0300 |
|---|---|---|
| committer | Jason Gunthorpe <jgg@nvidia.com> | 2020-08-31 12:10:11 -0300 |
| commit | 5d985d724bfa3ab7acf9edc2b3042f66fca9da99 (patch) | |
| tree | 497823999f59c87c4247510ec9a8247b7ad617e6 | |
| parent | RDMA/hns: Get udp sport num dynamically instead of using a fixed value (diff) | |
| download | linux-dev-5d985d724bfa3ab7acf9edc2b3042f66fca9da99.tar.xz linux-dev-5d985d724bfa3ab7acf9edc2b3042f66fca9da99.zip | |
RDMA/core: Trigger a WARN_ON if the driver causes uobjects to become leaked
Drivers that fail destroy can cause uverbs to leak uobjects. Drivers are
required to always eventually destroy their ubojects, so trigger a WARN_ON
to detect this driver bug.
Link: https://lore.kernel.org/r/0-v1-b1e0ed400ba9+f7-warn_destroy_ufile_hw_jgg@nvidia.com
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
| -rw-r--r-- | drivers/infiniband/core/rdma_core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/rdma_core.c b/drivers/infiniband/core/rdma_core.c index 6d3ed7c6e19e..e1c616e47d2b 100644 --- a/drivers/infiniband/core/rdma_core.c +++ b/drivers/infiniband/core/rdma_core.c @@ -895,8 +895,9 @@ void uverbs_destroy_ufile_hw(struct ib_uverbs_file *ufile, if (__uverbs_cleanup_ufile(ufile, reason)) { /* * No entry was cleaned-up successfully during this - * iteration + * iteration. It is a driver bug to fail destruction. */ + WARN_ON(!list_empty(&ufile->uobjects)); break; } |