diff options
| author |   Wei Hu(Xavier) <xavier.huwei@huawei.com> | 2017-09-29 23:10:12 +0800 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2017-09-29 12:10:09 -0400 |
| commit | 5e437b1d7e8d31ff9a4b8e898eb3a6cee309edd9 (patch) | |
| tree | 4886293d582042476f50081bf124cc066ba816aa | |
| parent | RDMA/hns: Set rdma_ah_attr type for querying qp (diff) | |
| download | linux-dev-5e437b1d7e8d31ff9a4b8e898eb3a6cee309edd9.tar.xz linux-dev-5e437b1d7e8d31ff9a4b8e898eb3a6cee309edd9.zip | |
RDMA/hns: Avoid NULL pointer exception
After the loop in hns_roce_v1_mr_free_work_fn function, it is possible that
all qps will have been freed (in which case ne will be 0). If that
happens, then later in the function when we dereference hr_qp we will
get an exception. Check ne is not 0 to make sure we actually have an
hr_qp left to work on.
This patch fixes the smatch error as below:
drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1009 hns_roce_v1_mr_free_work_fn()
error: we previously assumed 'hr_qp' could be null
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
| -rw-r--r-- | drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index 98887dd8ccb3..852db18ec128 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c @@ -1004,6 +1004,11 @@ static void hns_roce_v1_mr_free_work_fn(struct work_struct *work) } } + if (!ne) { + dev_err(dev, "Reseved loop qp is absent!\n"); + goto free_work; + } + do { ret = hns_roce_v1_poll_cq(&mr_free_cq->ib_cq, ne, wc); if (ret < 0) { |