aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>2010-08-04 13:23:02 +1000
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2010-08-04 14:38:55 +1000
commit5e6f6aa1c243fafeb2648cf4ebd5abd99ab2531b (patch)
tree6ebf6e67122fe8d859e8e59b3ce1c08a71ebf678
parentmemblock: Implement memblock_is_memory and memblock_is_region_memory (diff)
downloadlinux-dev-5e6f6aa1c243fafeb2648cf4ebd5abd99ab2531b.tar.xz
linux-dev-5e6f6aa1c243fafeb2648cf4ebd5abd99ab2531b.zip
memblock/arm: pfn_valid uses memblock_is_memory()
The implementation is pretty much similar. There is a -small- added overhead by having another function call and the address shift. If that becomes a concern, I suppose we could actually have memblock itself expose a memblock_pfn_valid() which then ARM can use directly with an appropriate #define... Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--arch/arm/mm/init.c15
1 files changed, 1 insertions, 14 deletions
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index d1496e65dc2d..e739223e2a54 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -237,20 +237,7 @@ static void __init arm_bootmem_free(struct meminfo *mi, unsigned long min,
#ifndef CONFIG_SPARSEMEM
int pfn_valid(unsigned long pfn)
{
- struct memblock_type *mem = &memblock.memory;
- unsigned int left = 0, right = mem->cnt;
-
- do {
- unsigned int mid = (right + left) / 2;
-
- if (pfn < memblock_start_pfn(mem, mid))
- right = mid;
- else if (pfn >= memblock_end_pfn(mem, mid))
- left = mid + 1;
- else
- return 1;
- } while (left < right);
- return 0;
+ return memblock_is_memory(pfn << PAGE_SHIFT);
}
EXPORT_SYMBOL(pfn_valid);