diff options
| author |   Guo Zhengkui <guozhengkui@vivo.com> | 2022-04-12 11:20:58 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-04-13 12:20:58 +0100 |
| commit | 5ee6ad1dcae8be7c101d1ffb2bbf4a01670e66cc (patch) | |
| tree | 45125dffe14635b658b8abf940ca1a99a02d5e0b | |
| parent | selftests: net: fib_rule_tests: add support to select a test to run (diff) | |
| download | linux-dev-5ee6ad1dcae8be7c101d1ffb2bbf4a01670e66cc.tar.xz linux-dev-5ee6ad1dcae8be7c101d1ffb2bbf4a01670e66cc.zip | |
ipv6: exthdrs: use swap() instead of open coding it
Address the following coccicheck warning:
net/ipv6/exthdrs.c:620:44-45: WARNING opportunity for swap()
by using swap() for the swapping of variable values and drop
the tmp (`addr`) variable that is not needed any more.
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv6/exthdrs.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 658d5eabaf7e..a2094aa1cb32 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c @@ -487,7 +487,6 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb) struct net *net = dev_net(skb->dev); struct inet6_dev *idev; struct ipv6hdr *oldhdr; - struct in6_addr addr; unsigned char *buf; int accept_rpl_seg; int i, err; @@ -616,9 +615,7 @@ looped_back: return -1; } - addr = ipv6_hdr(skb)->daddr; - ipv6_hdr(skb)->daddr = ohdr->rpl_segaddr[i]; - ohdr->rpl_segaddr[i] = addr; + swap(ipv6_hdr(skb)->daddr, ohdr->rpl_segaddr[i]); ipv6_rpl_srh_compress(chdr, ohdr, &ipv6_hdr(skb)->daddr, n); |