diff options
| author |   Dan Carpenter <error27@gmail.com> | 2011-06-13 23:10:49 +0300 |
|---|---|---|
| committer |   Nicholas Bellinger <nab@linux-iscsi.org> | 2011-06-24 00:03:51 +0000 |
| commit | 5eff5be0b1993f4291f2b8c6d035b408010f96c5 (patch) | |
| tree | 6388265637ceb3420ab114579bd56eac43f85ca6 | |
| parent | target: Fix ERR_PTR dereferencing bugs (diff) | |
| download | linux-dev-5eff5be0b1993f4291f2b8c6d035b408010f96c5.tar.xz linux-dev-5eff5be0b1993f4291f2b8c6d035b408010f96c5.zip | |
target: Drop bogus ERR_PTR usage in target_fabric_configfs_init
In the original code, there were several places inside the
target_fabric_configfs_init() function that returned NULL on error
and one place the returned an ERR_PTR. There are two places that
call this function and they only check for NULL returns; they don't
check for ERR_PTRs. So I've changed the ERR_PTR so now the function
only returns NULL on error.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| -rw-r--r-- | drivers/target/target_core_configfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index ee6fad979b50..b17abd13c8e3 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -312,7 +312,7 @@ struct target_fabric_configfs *target_fabric_configfs_init( tf = kzalloc(sizeof(struct target_fabric_configfs), GFP_KERNEL); if (!(tf)) - return ERR_PTR(-ENOMEM); + return NULL; INIT_LIST_HEAD(&tf->tf_list); atomic_set(&tf->tf_access_cnt, 0); |