diff options
| author |   Liu Bo <bo.li.liu@oracle.com> | 2017-05-15 17:20:07 -0700 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2017-06-19 18:25:59 +0200 |
| commit | 629ebf4fadbc647e2118ef9c94b038eeef178e9c (patch) | |
| tree | a38e9de4eab42a3354b46a0da0a2600b042b626f | |
| parent | Btrfs: change how we iterate bios in endio (diff) | |
| download | linux-dev-629ebf4fadbc647e2118ef9c94b038eeef178e9c.tar.xz linux-dev-629ebf4fadbc647e2118ef9c94b038eeef178e9c.zip | |
Btrfs: record error if one block has failed to retry
In the nocsum case of dio read endio, it returns immediately if an error
gets returned when repairing, which leaves the rest blocks unrepaired. The
behavior is different from how buffered read endio works in the same case.
This changes it to record error only and go on repairing the rest blocks.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/inode.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index ce6a9b2cce51..d8d1fe5096b7 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -8078,6 +8078,7 @@ static int __btrfs_correct_data_nocsum(struct inode *inode, u32 sectorsize; int nr_sectors; int ret; + int err = 0; fs_info = BTRFS_I(inode)->root->fs_info; sectorsize = fs_info->sectorsize; @@ -8099,8 +8100,10 @@ next_block_or_try_again: pgoff, start, start + sectorsize - 1, io_bio->mirror_num, btrfs_retry_endio_nocsum, &done); - if (ret) - return ret; + if (ret) { + err = ret; + goto next; + } wait_for_completion(&done.done); @@ -8109,6 +8112,7 @@ next_block_or_try_again: goto next_block_or_try_again; } +next: start += sectorsize; nr_sectors--; @@ -8119,7 +8123,7 @@ next_block_or_try_again: } } - return 0; + return err; } static void btrfs_retry_endio(struct bio *bio) |