diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2013-11-13 10:42:34 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-11-14 03:10:30 -0500 |
| commit | 64b8c8e573f614853c6cb828b2853da8e285377f (patch) | |
| tree | 78a7ab5f3fc27209cf0fa7b3fde4271af30efd62 | |
| parent | core/dev: do not ignore dmac in dev_forward_skb() (diff) | |
| download | linux-dev-64b8c8e573f614853c6cb828b2853da8e285377f.tar.xz linux-dev-64b8c8e573f614853c6cb828b2853da8e285377f.zip | |
net: cdc_ncm: cleanup a type issue in cdc_ncm_setup()
This is harmless but cdc_ncm_setup() returns negative error codes
truncated to u8 values. There is only one caller and treats all
non-zero returns as errors but doesn't store the the return code. So
the code works correctly but it's messy and upsets the static checkers.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/cdc_ncm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index f74786aa37be..e15ec2b12035 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -66,7 +66,7 @@ static void cdc_ncm_tx_timeout_start(struct cdc_ncm_ctx *ctx); static enum hrtimer_restart cdc_ncm_tx_timer_cb(struct hrtimer *hr_timer); static struct usb_driver cdc_ncm_driver; -static u8 cdc_ncm_setup(struct usbnet *dev) +static int cdc_ncm_setup(struct usbnet *dev) { struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0]; struct usb_cdc_ncm_ntb_parameters ncm_parm; |