aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhao Hongjiang <zhaohongjiang@huawei.com>2012-10-09 13:48:47 +0800
committerJan Kara <jack@suse.cz>2012-10-09 23:24:03 +0200
commit66415f6b50f5bcbc56c78df54aacee73f3d03a3d (patch)
tree5aff60871f991db6466dbdf90e28412650ff0e41
parentext2: fix return values on parse_options() failure (diff)
downloadlinux-dev-66415f6b50f5bcbc56c78df54aacee73f3d03a3d.tar.xz
linux-dev-66415f6b50f5bcbc56c78df54aacee73f3d03a3d.zip
ext3: fix return values on parse_options() failure
parse_options() in ext3 should return 0 when parse the mount options fails. Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com> Reviewed-by: Lukas Czerner <lczerner@redhat.com> Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r--fs/ext3/super.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 17ae5c83d234..ebf8312c3a4e 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
uid = make_kuid(current_user_ns(), option);
if (!uid_valid(uid)) {
ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
- return -1;
+ return 0;
}
sbi->s_resuid = uid;
@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
gid = make_kgid(current_user_ns(), option);
if (!gid_valid(gid)) {
ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
- return -1;
+ return 0;
}
sbi->s_resgid = gid;
break;