diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-23 11:09:00 +0800 |
|---|---|---|
| committer |   Marcel Holtmann <marcel@holtmann.org> | 2018-07-23 18:05:00 +0200 |
| commit | 6709514f266e9163f9f579006496fbc8bc986d80 (patch) | |
| tree | 14e2ebf129e953137d4c868daad64379ba57ca51 | |
| parent | Bluetooth: Use lock_sock_nested in bt_accept_enqueue (diff) | |
| download | linux-dev-6709514f266e9163f9f579006496fbc8bc986d80.tar.xz linux-dev-6709514f266e9163f9f579006496fbc8bc986d80.zip | |
bluetooth: bfusb: Replace GFP_ATOMIC with GFP_KERNEL in bfusb_send_frame()
bfusb_send_frame() is only set to hdev->send, and hdev->send() is never
called in atomic context.
bfusb_send_frame() calls bt_skb_alloc() with GFP_ATOMIC, which is not
necessary. GFP_ATOMIC can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
| -rw-r--r-- | drivers/bluetooth/bfusb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c index ab090a313a5f..0588639b899a 100644 --- a/drivers/bluetooth/bfusb.c +++ b/drivers/bluetooth/bfusb.c @@ -490,7 +490,7 @@ static int bfusb_send_frame(struct hci_dev *hdev, struct sk_buff *skb) count = skb->len; /* Max HCI frame size seems to be 1511 + 1 */ - nskb = bt_skb_alloc(count + 32, GFP_ATOMIC); + nskb = bt_skb_alloc(count + 32, GFP_KERNEL); if (!nskb) { BT_ERR("Can't allocate memory for new packet"); return -ENOMEM; |