diff options
| author |   Vatsala Narang <vatsalanarang@gmail.com> | 2019-04-27 21:37:49 +0530 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-30 15:00:31 +0200 |
| commit | 675c8a46a8cc8a15f64863fd4c7786df2b5b728b (patch) | |
| tree | 0f88f79d3408c51f6d17b75df1d00c5fdbb70b0a | |
| parent | staging: rtl8723bs: Fix checkpatch.pl warnings (diff) | |
| download | linux-dev-675c8a46a8cc8a15f64863fd4c7786df2b5b728b.tar.xz linux-dev-675c8a46a8cc8a15f64863fd4c7786df2b5b728b.zip | |
staging: vc04_services: bcm2835-camera: Modify return statement.
Modify return statement and remove the respective assignment.
Issue found by Coccinelle.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/vc04_services/bcm2835-camera/controls.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index 2e0a422cdf3e..9841c30450ce 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -270,11 +270,9 @@ static int ctrl_set_rotate(struct bm2835_mmal_dev *dev, if (ret < 0) return ret; - ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], + return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], mmal_ctrl->mmal_id, &u32_value, sizeof(u32_value)); - - return ret; } static int ctrl_set_flip(struct bm2835_mmal_dev *dev, @@ -313,11 +311,9 @@ static int ctrl_set_flip(struct bm2835_mmal_dev *dev, if (ret < 0) return ret; - ret = vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], + return vchiq_mmal_port_parameter_set(dev->instance, &camera->output[2], mmal_ctrl->mmal_id, &u32_value, sizeof(u32_value)); - - return ret; } static int ctrl_set_exposure(struct bm2835_mmal_dev *dev, |