diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-16 00:46:19 +0200 |
|---|---|---|
| committer |   Kalle Valo <kvalo@kernel.org> | 2022-07-27 15:51:53 +0300 |
| commit | 69ddcea564437ce4b0d5143f37a9154fcef8d3d2 (patch) | |
| tree | 86ed5b3a31124ffff45538dc93d67351ee653b57 | |
| parent | wifi: libertas: Fix possible refcount leak in if_usb_probe() (diff) | |
| download | linux-dev-69ddcea564437ce4b0d5143f37a9154fcef8d3d2.tar.xz linux-dev-69ddcea564437ce4b0d5143f37a9154fcef8d3d2.zip | |
wifi: wl12xx: Drop if with an always false condition
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
(in wlcore_probe()) and so wl is never NULL.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220715224619.ht7bbzzrmysielm7@pengutronix.de
| -rw-r--r-- | drivers/net/wireless/ti/wl12xx/main.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/wireless/ti/wl12xx/main.c b/drivers/net/wireless/ti/wl12xx/main.c index c6da0cfb4afb..d06a2c419447 100644 --- a/drivers/net/wireless/ti/wl12xx/main.c +++ b/drivers/net/wireless/ti/wl12xx/main.c @@ -1924,13 +1924,10 @@ static int wl12xx_remove(struct platform_device *pdev) struct wl1271 *wl = platform_get_drvdata(pdev); struct wl12xx_priv *priv; - if (!wl) - goto out; priv = wl->priv; kfree(priv->rx_mem_addr); -out: return wlcore_remove(pdev); } |