diff options
| author |   Steffen Klassert <steffen.klassert@secunet.com> | 2017-10-09 08:43:55 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-09 09:39:50 -0700 |
| commit | 6c0e7284d89995877740d8a26c3e99a937312a3c (patch) | |
| tree | e8867c1be1012cf7cfd43bcb7144cb84370114ed | |
| parent | ipv6: Fix traffic triggered IPsec connections. (diff) | |
| download | linux-dev-6c0e7284d89995877740d8a26c3e99a937312a3c.tar.xz linux-dev-6c0e7284d89995877740d8a26c3e99a937312a3c.zip | |
ipv4: Fix traffic triggered IPsec connections.
A recent patch removed the dst_free() on the allocated
dst_entry in ipv4_blackhole_route(). The dst_free() marked the
dst_entry as dead and added it to the gc list. I.e. it was setup
for a one time usage. As a result we may now have a blackhole
route cached at a socket on some IPsec scenarios. This makes the
connection unusable.
Fix this by marking the dst_entry directly at allocation time
as 'dead', so it is used only once.
Fixes: b838d5e1c5b6 ("ipv4: mark DST_NOGC and remove the operation of dst_free()")
Reported-by: Tobias Brunner <tobias@strongswan.org>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index ac6fde5d45f1..3d9f1c2f81c5 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2513,7 +2513,7 @@ struct dst_entry *ipv4_blackhole_route(struct net *net, struct dst_entry *dst_or struct rtable *ort = (struct rtable *) dst_orig; struct rtable *rt; - rt = dst_alloc(&ipv4_dst_blackhole_ops, NULL, 1, DST_OBSOLETE_NONE, 0); + rt = dst_alloc(&ipv4_dst_blackhole_ops, NULL, 1, DST_OBSOLETE_DEAD, 0); if (rt) { struct dst_entry *new = &rt->dst; |